Fix: remove ISafe interface in the function handler handle function signature
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
requested review from
a team,
rmeissner,
Uxio0 and
akshay-ap
and removed request for
a team
mmv08
changed the title
handle function signature
rmeissner
approved these changes
Sep 8, 2023
Yes, I mentioned this in the PR description. I will create a PR later today. |
mmv08
added a commit
to 5afe/safe-core-protocol-specs
that referenced
this pull request
Sep 11, 2023
This PR addresses the problem discovered in 5afe/safe-core-protocol#99 The motivation behind these changes: - Developers should decide which interface to use, as they'll be calling the methods on the account - The protocol is considered to be account-agnostic, as long as the account implements the methods required by the specification (to be defined later), so the API may differ across accounts
akshay-ap
approved these changes
Sep 11, 2023
mmv08
added a commit
to 5afe/safe-core-protocol-specs
that referenced
this pull request
Sep 11, 2023
This PR addresses the problem discovered in 5afe/safe-core-protocol#99 The motivation behind these changes: - Developers should decide which interface to use, as they'll be calling the methods on the account - The protocol is considered to be account-agnostic, as long as the account implements the methods required by the specification (to be defined later), so the API may differ across accounts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a blocker while working on the ERC4337 function handler, I inherited
ISafeProtocolFunctionHandler, and I couldn't get my contract to compile because the handle function had to acceptISafe safeas a first argument, but the interface used in the function wasn't any useful for me as it only defined two module execution functions which are irrelevant outside of the protocol context since they're only used for protocol transactions only. I believe this is not needed for two reasons:The specs PR: 5afe/safe-core-protocol-specs#38