Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC165 check when enabling plugin #73

Closed
akshay-ap opened this issue Aug 21, 2023 · 0 comments · Fixed by #74
Closed

ERC165 check when enabling plugin #73

akshay-ap opened this issue Aug 21, 2023 · 0 comments · Fixed by #74
Assignees
@akshay-ap
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@akshay-ap
Copy link
Contributor

When enabling a plugin, check if address implements ISafeProtocolPlugin interface.
@akshay-ap akshay-ap self-assigned this Aug 21, 2023
@akshay-ap akshay-ap added this to the v0.2.0 milestone Aug 21, 2023
@akshay-ap akshay-ap added the enhancement New feature or request label Aug 21, 2023
akshay-ap added a commit that referenced this issue Aug 21, 2023
@akshay-ap
[#73] Check if plugin supports expected interface Id when enabling
52ae52f
@akshay-ap akshay-ap mentioned this issue Aug 21, 2023
Merged
akshay-ap added a commit that referenced this issue Aug 22, 2023
@akshay-ap
[#73] Fix lint issue
c9b8c80
akshay-ap added a commit that referenced this issue Aug 23, 2023
@akshay-ap
[#73] Add test for Manager: block EOA as Plugin
f44918a
github-merge-queue bot pushed a commit that referenced this issue Aug 23, 2023
@akshay-ap
Check if plugin supports expected interface Id when enabling (#74)
1fdfc1b 
* [#46] Implement Guard interface in SafeProtocolManager

* [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager

* [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler

* [#47] Update natspec doc

* [#46] Setup Safe

* [#46] Fix EOF

* [#46] User setupTest function

* [#46] Fix lint issue

* [#46] Add tests

* [#46] Add test with delegateCall for hooks flow

* [#46] User temporary variable for storing hooks address

* [#47] Implement logic for non-static calls to function handler manager, test to set function handler

* [#47] Add tests for Function Handler

* [#47] Pass sender address in handle function

* [#47] Fix test

* [#47] Use ZeroAddress from ethers

* [#46] Reset tempHooksAddress

* [#47] Test static call to function handler

* [#47] Fix lint issue

* [#47] Fix typo

* [#46] Refactor tests for SafeProtocolManager as Guard

* [#46] Fix failing test

* [#46] Update comment

* [#47] Update tests for Function Handler

* [#47] Update tests for function handler

* [#47] Remove test function handler from .solcover.js

* [#47] Return data from handle function

* [#47] Verify call data passed to handle(...)

* [#47] Update doc string

* [#47] Check if function handler is whitelisted

* [#47] Make fallback function non-payable, optimize codesize

* [#47] Fix lint issue

* [#47] Add ERC165 check while adding function handler

* [#47] Allow only self calls to manager

* [#47] Add tests for function handler

* [#47] Add tests

* [#47] Rename function to `checkCallerisSender()`

* [#47] Rename to OnlyAccountCallable, add docstrings

* [#47] Update string in describe

* [#47] Update natspec doc for RegistryManager constructor

* [#47] Update natspec doc for FunctionHandlerManager

* [#73] Check if plugin supports expected interface Id when enabling

* [#73] Fix lint issue

* [#73] Add test for Manager: block EOA as Plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Check if plugin supports expected interface Id when enabling 5afe/safe-core-protocol
1 participant
@akshay-ap