Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disableplugin(...) does not update pointers in the linkedlist #71

Closed
akshay-ap opened this issue Aug 17, 2023 · 0 comments · Fixed by #72
Closed

disableplugin(...) does not update pointers in the linkedlist #71

akshay-ap opened this issue Aug 17, 2023 · 0 comments · Fixed by #72
Assignees
@akshay-ap
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@akshay-ap
Copy link
Contributor

The line attempts to update the pointers in the linked list but does not really update it!

safe-core-protocol/contracts/SafeProtocolManager.sol

Line 215 in e68bd14

prevPluginInfo = pluginInfo;

This is not captured in tests because there is no test that checks getPluginsPaginated(...) after disabling a Plugin!

Fix:

prevPluginInfo.nextPluginPointer = pluginInfo.nextPluginPointer;
prevPluginInfo.rootAddressGranted = pluginInfo.rootAddressGranted;
@akshay-ap akshay-ap added the bug Something isn't working label Aug 17, 2023
@akshay-ap akshay-ap added this to the v0.2.0 milestone Aug 17, 2023
@akshay-ap akshay-ap self-assigned this Aug 17, 2023
akshay-ap added a commit that referenced this issue Aug 17, 2023
@akshay-ap
[#71] Update linkedlist pointers when disabling plugin
ddc18dd
akshay-ap added a commit that referenced this issue Aug 17, 2023
@akshay-ap
[#71] Update linkedlist pointers when disabling plugin
fa7834d
@akshay-ap akshay-ap mentioned this issue Aug 17, 2023
Merged
@akshay-ap akshay-ap changed the title Disable plugin does not update struct disableplugin(...) does not update pointers in the linkedlist Aug 17, 2023
akshay-ap added a commit that referenced this issue Aug 17, 2023
@akshay-ap
[#71] Add test: Disable 1 out of 3 plugin and fetch list
06eaf26
akshay-ap added a commit that referenced this issue Aug 17, 2023
@akshay-ap
[#71] Check if plugin is disabled
fda83d4
github-merge-queue bot pushed a commit that referenced this issue Aug 17, 2023
@akshay-ap
Update linkedlist pointers when disabling plugin (#72)
df4648d 
* [#71] Update linkedlist pointers when disabling plugin

* [#71] Add test: Disable 1 out of 3 plugin and fetch list

* [#71] Check if plugin is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay-ap akshay-ap

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Update linkedlist pointers when disabling plugin 5afe/safe-core-protocol
1 participant
@akshay-ap