You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are caching prices provider responses based on query parameters. These parameters may include multipl token addresses, of varying order, e.g. {url}?token=a,b,c vs. {url}?token=b,a,c. As such, we are caching inconsistently.
We should be caching token info per address, checking whether they exist first before requesting those missing. This will, in turn, reduce the number of requests to our prices provider.
Reproduction steps
Request prices of tokens in a certain order.
Adjust order and request again.
Observe cache miss on second request.
Expected behavior
Cache hit should occur for given example.
Additional information
No response
The text was updated successfully, but these errors were encountered:
Description
We are caching prices provider responses based on query parameters. These parameters may include multipl token addresses, of varying order, e.g.
{url}?token=a,b,c
vs.{url}?token=b,a,c
. As such, we are caching inconsistently.We should be caching token info per address, checking whether they exist first before requesting those missing. This will, in turn, reduce the number of requests to our prices provider.
Reproduction steps
Observe cache miss on second request.
Expected behavior
Cache hit should occur for given example.
Additional information
No response
The text was updated successfully, but these errors were encountered: