Test with PHP8.0 #82
Merged
Test with PHP8.0 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage 99.72% 99.72%
Complexity 111 111
=========================================
Files 9 9
Lines 364 364
=========================================
Hits 363 363
Misses 1 1 Continue to review full report at Codecov.
|
|
https://travis-ci.org/github/sabre-io/event/jobs/732476526 on PHP 8.0 good |
phil-davis
commented
Oct 3, 2020
| @@ -16,7 +16,7 @@ | |||
| "homepage": "http://sabre.io/event/", | |||
| "license": "BSD-3-Clause", | |||
| "require": { | |||
| "php": "^7.1|^8.0" | |||
| "php": "^7.1 || ^8.0" | |||
There was a problem hiding this comment.
Note: I adjusted this to have the same || or format as in other repos, just to be consistent.
staabm
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.ymlfor selecting to run php-cs-fixer, phpunit and phpstancomposer.json(because php-cs-fixer does not yet support PHP 8.0, so composer cannot sort out dependencies if we have PHP 8.0 and php-cs-fixer 2.* together)Note: PR #77 actually enabled PHP 8.0 in
composer.jsonalready, so this PR just gets CI running the unit tests with PHP 8.0