Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "row" as "section" or "block" #14

Open
jasonm23 opened this issue Apr 29, 2015 · 10 comments
Open

Rename "row" as "section" or "block" #14

jasonm23 opened this issue Apr 29, 2015 · 10 comments

Comments

@jasonm23
Copy link
Collaborator

Since row's aren't literal rows they should be named something more fitting. e.g. section or block

@jasonm23 jasonm23 changed the title Repurpose "row" as "section" Rename "row" as "section" or "block" Apr 29, 2015
@sabof
Copy link
Owner

sabof commented Apr 29, 2015

Not in the table-row sense. Still they display items one after another, so the term is relevant.

@jasonm23
Copy link
Collaborator Author

I think people would find it more confusing than useful. It's not a big deal to change it now since the package is woefully under-used.

If my themes packages are sucessful there'll be at least a thousand users, and some will be developing themes.

This is the only opportunity we have to reshape the API.

We should always follow the principle of least surprise. While row is valid, the context of rows and columns here is high.

I also think we can extend blocks, so that they are just things which contain widgets. (Not necessarily in column / row sense.)

Something more all-encompassing and general is more intuitive, so helps people develop with the kit.

@jasonm23
Copy link
Collaborator Author

I don't mind doing the leg work, I just want to make sure I get your blessing.

@sabof
Copy link
Owner

sabof commented Apr 30, 2015

I'll think about it.

@sabof
Copy link
Owner

sabof commented Apr 30, 2015

Another possibility would be to make them a type of widget, that can contain other widgets. I'm not sure though how much more useful it will be than the current approach.

@jasonm23
Copy link
Collaborator Author

I think that would be a nice way too.

If we have a single container object which manages its children's (as type of self) placement that would be good.

@sabof
Copy link
Owner

sabof commented Apr 30, 2015

I also thought about span. Overall I doubt non-horizontal arrangements will be common, given it's a mode line.

@jasonm23
Copy link
Collaborator Author

I think what I'm doing may well change that perception.

@sabof
Copy link
Owner

sabof commented Apr 30, 2015

"row" still sounds better to my ears. I'll leave the ticket open, in case there are other objections.

@sabof
Copy link
Owner

sabof commented May 3, 2015

"group" might be better, but I'd rather do the renaming after any possible functional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants