-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "row" as "section" or "block" #14
Comments
Not in the table-row sense. Still they display items one after another, so the term is relevant. |
I think people would find it more confusing than useful. It's not a big deal to change it now since the package is woefully under-used. If my themes packages are sucessful there'll be at least a thousand users, and some will be developing themes. This is the only opportunity we have to reshape the API. We should always follow the principle of least surprise. While row is valid, the context of rows and columns here is high. I also think we can extend blocks, so that they are just things which contain widgets. (Not necessarily in column / row sense.) Something more all-encompassing and general is more intuitive, so helps people develop with the kit. |
I don't mind doing the leg work, I just want to make sure I get your blessing. |
I'll think about it. |
Another possibility would be to make them a type of widget, that can contain other widgets. I'm not sure though how much more useful it will be than the current approach. |
I think that would be a nice way too. If we have a single container object which manages its children's (as type of self) placement that would be good. |
I also thought about |
I think what I'm doing may well change that perception. |
"row" still sounds better to my ears. I'll leave the ticket open, in case there are other objections. |
"group" might be better, but I'd rather do the renaming after any possible functional changes. |
Since row's aren't literal rows they should be named something more fitting. e.g. section or block
The text was updated successfully, but these errors were encountered: