-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuke the proxy targets #224
Comments
why does it matter if they are audited or not? for example, the Archive and the Proxy Plugin are also audited, but we won't keep them as they are not relevant to
hmm, don't think we should keep them. we can always use git history (checkout to a specific commit) if there's an actual need to deploy them. the problem with keeping them in the repo (on the also, i think we both agree that we should not release the NPM package with them, right? i suggest we remove them for |
good points, let's remove them |
If the intention is for integrators to use the latest Periphery v2.1 contracts natively (no proxy), removing the targets should be the way to go. One important thing here is keeping historical references to v2.0 inside out documentation, given:
I'm mentioning this for posterity as I believe this final caveat is already addressed by @andreivladbrg's idea around a nested deployment-addresses documentation. At the same time, we could move the pages addressing v2.0 targets into a "deprecated" section, just so we can keep linking to them (e.g. offer a short explainer/changelog between versions in the docs and add references to those pages). P.S. I know this is more relevant to v2-docs but it felt important to also have it part of this discussion. |
We can just share a historical deployment URL from Vercel |
Addressed in 6362f22 |
The PR that implements this issue should target the
2.2
branch because the proxy targets are already audited and we should keep them in version control just in case we need to deploy them.The text was updated successfully, but these errors were encountered: