Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make withdraw function callable by any account #731

Closed
PaulRBerg opened this issue Nov 28, 2023 · 2 comments · Fixed by #785
Closed

Make withdraw function callable by any account #731

PaulRBerg opened this issue Nov 28, 2023 · 2 comments · Fixed by #785
Assignees
@smol-ninja
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

The task is to allow the withdraw function to be callable by anyone so that third-party accounts can claim on behalf of recipients.

See the rationale in #110 (especially towards the bottom).
@andreivladbrg
Copy link
Member

I suppose that this change is meant to be for 2.2, right?

@PaulRBerg PaulRBerg added this to the V2.2 milestone Dec 4, 2023
@PaulRBerg
Copy link
Member Author

Correct. I linked it to the V2.2 milestone.

@PaulRBerg PaulRBerg added type: feature New feature or request. effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. and removed backlog labels Jan 1, 2024
@andreivladbrg andreivladbrg moved this to 📋 Not Started in Lockup 1.2.0 Jan 4, 2024
@PaulRBerg PaulRBerg removed this from the V2.2 milestone Jan 4, 2024
@smol-ninja smol-ninja moved this from 📋 Not Started to 🏗 In progress in Lockup 1.2.0 Jan 6, 2024
@smol-ninja smol-ninja mentioned this issue Jan 8, 2024
Merged
@smol-ninja smol-ninja moved this from 🏗 In progress to 👀 In review in Lockup 1.2.0 Jan 8, 2024
@smol-ninja smol-ninja moved this from 👀 In review to ✅ Done in Lockup 1.2.0 Jan 23, 2024
@smol-ninja smol-ninja mentioned this issue Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
No open projects
Lockup 1.2.0
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: "withdraw" callable by any account, removes "to" from "withdrawMultiple" sablier-labs/v2-core
3 participants
@smol-ninja @PaulRBerg @andreivladbrg