Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for the case when the "sender" differs from the "msg.sender" in the tests for the "create" function #56

Closed
PaulRBerg opened this issue Jun 15, 2022 · 0 comments · Fixed by #82
Closed

Add a test for the case when the "sender" differs from the "msg.sender" in the tests for the "create" function #56

PaulRBerg opened this issue Jun 15, 2022 · 0 comments · Fixed by #82

Comments

@PaulRBerg
Copy link
Member

This would in effect mean that the msg.senders "donates" the stream to the sender.
@PaulRBerg PaulRBerg added testing duplicate This issue or pull request already exists. labels Jun 15, 2022
@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2022
@PaulRBerg PaulRBerg reopened this Jun 21, 2022
@PaulRBerg PaulRBerg removed the duplicate This issue or pull request already exists. label Jun 21, 2022
@PaulRBerg PaulRBerg mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test when the caller is not the sender of the stream sablier-labs/v2-core
1 participant
@PaulRBerg