Should we check if startTime is zero in LD and LT?

[andreivladbrg]

In LockupLinear, we no longer allow startTime == 0. This change has been implemented because we now set cliffTime == 0 to create a linear curve stream.

However, this has introduced inconsistency across contracts. In LockupDynamic and LockupTranched, the start time can still be zero.

Should we also disallow a start time of zero in LockupDynamic and LockupTranched?
What are your thoughts? @PaulRBerg @smol-ninja

[PaulRBerg]

Should we also disallow a start time of zero in LockupDynamic and LockupTranched?

Yes

---

Separately - I think you should have tagged @sablier-labs/engineers since this discussion is relevant for the front-end; cc @razgraf, @gavriliumircea.

[andreivladbrg]

I think you should have tagged @sablier-labs/engineers since this discussion is relevant for the front-end; cc @razgraf, @gavriliumircea.

yeah, my bad

[razgraf]

I don't think it affects us in any way (the UI doesn't allow start times of 0 anyway), so for the sake of consistency, go for it!

P.S. However, please do include this in the changelog we should follow for the v2.1 to v2.2 upgrade

[andreivladbrg]

Ended up implementing this in #852