Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voiding streams with negative debt for improved accounting #61

Closed
1 task done
PaulRBerg opened this issue Apr 30, 2024 Discussed in #57 · 0 comments · Fixed by #166
Closed
1 task done

Voiding streams with negative debt for improved accounting #61

PaulRBerg opened this issue Apr 30, 2024 Discussed in #57 · 0 comments · Fixed by #166
Assignees
@smol-ninja
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Apr 30, 2024 •
edited by smol-ninja
Loading

Discussed in #57

Originally posted by PaulRBerg April 30, 2024

Add a new function called void with the following requirements:

  • Can only be called by the recipient
  • Can only be called when the debt exceeds zero

And the following behavior:

  • Sets the debt to zero
  • Stops the stream from accruing debt in the future

Depends on
@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Apr 30, 2024
@smol-ninja smol-ninja assigned smol-ninja and unassigned smol-ninja May 22, 2024
@smol-ninja smol-ninja mentioned this issue Jun 6, 2024
Merged
@smol-ninja smol-ninja added work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. and removed work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ability to void stream by recipient sablier-labs/flow
3 participants
@smol-ninja @PaulRBerg @andreivladbrg