Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit BatchMetadataUpdate in setProtocolFee #305

Closed
smol-ninja opened this issue Oct 14, 2024 · 0 comments · Fixed by #306
Closed

emit BatchMetadataUpdate in setProtocolFee #305

smol-ninja opened this issue Oct 14, 2024 · 0 comments · Fixed by #306
Assignees
@smol-ninja
Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

From Cantina finding 13

The current version of the FlowNFTDescriptor contract responsible for the metadata JSON does not include the protocol fee as part of the metadata. However a future version of the NFTDescriptor can include the protocol fee and therefore a change of the fee should emit a BatchMetadataUpdate event so third parties can update the metadata accordingly. EIP-4906 also specifies that it MUST be emitted in this case.

The MetadataUpdate or BatchMetadataUpdate event MUST be emitted when the JSON metadata of a token, or a consecutive range of tokens, is changed.
@smol-ninja smol-ninja self-assigned this Oct 14, 2024
@smol-ninja smol-ninja added priority: 0 Do this first before everything else. This is critical and nothing works without this. effort: low Easy or tiny task that takes less than a day. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Oct 14, 2024
@smol-ninja smol-ninja mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: feature New feature or request. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: emit BatchMetadataUpdate in setProtocolFee sablier-labs/flow
1 participant
@smol-ninja