Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isPaused from storage slot and update snapshotTime in pause and void #276

Closed
2 tasks done
smol-ninja opened this issue Sep 30, 2024 · 0 comments · Fixed by #277
Closed
2 tasks done

Remove isPaused from storage slot and update snapshotTime in pause and void #276

smol-ninja opened this issue Sep 30, 2024 · 0 comments · Fixed by #277
Assignees
@smol-ninja
Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Sep 30, 2024 •
edited
Loading

As discussed in #269 and #271.

Tasks

  • Remove isPaused from storage and implement runtime check: rps == 0
  • Update snapshotTime in pause and void
@smol-ninja smol-ninja added priority: 0 Do this first before everything else. This is critical and nothing works without this. type: refactor Change that neither fixes a bug nor adds a feature. effort: low Easy or tiny task that takes less than a day. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Sep 30, 2024
@smol-ninja smol-ninja self-assigned this Sep 30, 2024
@smol-ninja smol-ninja mentioned this issue Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: low Easy or tiny task that takes less than a day. priority: 0 Do this first before everything else. This is critical and nothing works without this. type: refactor Change that neither fixes a bug nor adds a feature. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: isPaused, snapshot time, create function sablier-labs/flow
1 participant
@smol-ninja