Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-bod): change paths for local template development #166

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

sabertazimi
Copy link
Owner

@sabertazimi sabertazimi commented Sep 18, 2021

  • Stop watch and build cra-template-bod/template/ directory.
  • Direct start and test from cra-template-bod/src/ directory.
  • This change disable local development for cra-template and
    cra-template-typescript, cause they don't have src/ directory.

issue #19.

@sabertazimi sabertazimi added enhancement New feature or request todo 🗒️ labels Sep 18, 2021
@sabertazimi sabertazimi self-assigned this Sep 18, 2021
@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #166 (5992488) into main (97505df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           57        57           
  Branches         2         2           
=========================================
  Hits            57        57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97505df...5992488. Read the comment docs.

- Stop watch and build `cra-template-bod/template/` directory.
- Direct start and test from `cra-template-bod/src/` directory.
- This change disable local development for `cra-template` and
  `cra-template-typescript`, cause they don't have `/src/` directory.

issue #19.
@sabertazimi sabertazimi force-pushed the fix/local-template-development branch from 1027e95 to 5992488 Compare September 21, 2021 14:14
@sabertazimi sabertazimi merged commit d40ba22 into main Oct 10, 2021
@sabertazimi sabertazimi deleted the fix/local-template-development branch October 10, 2021 18:09
github-actions bot added a commit that referenced this pull request Oct 10, 2021
- Stop watch and build `cra-template-bod/template/` directory.
- Direct start and test from `cra-template-bod/src/` directory.
- This change disable local development for `cra-template` and
  `cra-template-typescript`, cause they don't have `/src/` directory.

issue #19. d40ba22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo 🗒️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant