Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update typescript-eslint monorepo to v6 (major) #1003

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 14, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@typescript-eslint/eslint-plugin ^5.62.0 -> ^6.0.0 age adoption passing confidence
@typescript-eslint/parser ^5.62.0 -> ^6.0.0 age adoption passing confidence

Release Notes

typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)

v6.0.0

Compare Source

Bug Fixes
  • bumped ts-api-utils to 0.0.39 (#​6497) (217c710)
  • correct handling of additionalProperties in object schemas (#​6939) (489c7a5)
  • correct lint error after merge (277fdb5)
  • eslint-plugin: [explicit-module-boundary-types] remove shouldTrackReferences option from schema (#​5399) (6d32734)
  • eslint-plugin: allow parser@^6.0.0 (#​6630) (92908bd)
  • eslint-plugin: remove valid-typeof disable in eslint-recommended (#​5381) (b82df5e)
  • fix illegal decorator check (#​6723) (c456f8c)
  • rename typeParameters to typeArguments where needed (#​5384) (08d757b)
  • replace tsutils with ts-api-tools (#​6428) (79327b4)
  • type-utils: treat intrinsic types as if they are from lib and never match error types (#​6869) (ecb57de)
  • typescript-estree: account for namespace nesting in AST conversion (#​6272) (09e3877)
  • update exports field in package.json files (#​6550) (53776c2)
chore
Features
BREAKING CHANGES
  • eslint-plugin: Adds an additional class of checks to the rule
  • drop support for ESLint v6
  • drops support for node v17
  • Bumps the minimum supported range and removes handling for old versions
  • drops support for node v12

You can read about our versioning strategy and releases on our website.

typescript-eslint/typescript-eslint (@​typescript-eslint/parser)

v6.0.0

Compare Source

Bug Fixes
chore
Features
BREAKING CHANGES
  • drop support for ESLint v6
  • drops support for node v17
  • drops support for node v12

You can read about our versioning strategy and releases on our website.


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jul 14, 2023
@renovate renovate bot requested a review from sabertazimi July 14, 2023 19:15
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1003 (7b2a776) into main (046d35b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1003   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           57        57           
  Branches         2         2           
=========================================
  Hits            57        57           

@pull-request-quantifier-deprecated

This PR has 8 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +4 -4
Percentile : 3.2%

Total files changed: 3

Change summary by file extension:
.json : +4 -4
.lock : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@sabertazimi sabertazimi merged commit ec9595a into main Jul 15, 2023
@sabertazimi sabertazimi deleted the renovate/major-typescript-eslint-monorepo branch July 15, 2023 11:24
github-actions bot added a commit that referenced this pull request Jul 15, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> ec9595a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Extra Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant