Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-peer code review [desktop version] #13

Open
JuanLPalacios opened this issue Jan 18, 2022 · 0 comments
Open

Peer-to-peer code review [desktop version] #13

JuanLPalacios opened this issue Jan 18, 2022 · 0 comments

Comments

@JuanLPalacios
Copy link
Collaborator

an overall great work especially on the HTML structure but here are some points to improve:

  • on the first section the background image is repeating and doesn't look great, I'd suggest the use of background-size: cover to prevent that.
  • the CSS sometimes presents selectors with 4 jumps while some browsers only support 3
  • the header is inside the first section but technically is not part of the first section, I'd suggest the use of position absolute for the header so that it does not push the section down and depending on if they are needed background: transparent or z-index as you see fit
  • links could point to sections by their id
@JuanLPalacios JuanLPalacios changed the title Peer-to-peer code review [desktop versión] Peer-to-peer code review [desktop version] Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant