Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling getting broken when defining a custom onServerSearch function #325

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Apr 21, 2024

What was happening

  • To replicate it:
    1. Open the screen with an example of the implementation impacted (here)
    2. Search for "a"
    3. Scroll down with either the mouse or the scrollbar
    4. Check that the dropdown doesn't work as expected

#319_Issue

After the fix

  • The fix was on the method setServerOptions()
  • Fixed the issues that were being thrown by executing npm run validate
  • Fixed vulnerabilities found by executing npm audit
  • To replicate it:
    1. Open the screen with an example of the implementation impacted using the new file in the dist folder
    2. Search for "a"
    3. Scroll down with either the mouse or the scrollbar
    4. Check that the dropdown doesn't work as expected

IssueDropdownOnServerSearchFix

Final validations

  • Followed the same steps above - ✅
  • Ran regression scenarios - ✅
  • Run automated tests - ✅

image

docs/assets/virtual-select.js Show resolved Hide resolved
@gnbm gnbm marked this pull request as ready for review April 23, 2024 17:33
@gnbm gnbm merged commit 630053d into master Apr 23, 2024
@gnbm gnbm deleted the Issue319 branch April 23, 2024 20:22
@gnbm gnbm mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants