Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an admin panel option when setting up the template #126

Open
haffi96 opened this issue Oct 5, 2022 · 7 comments
Open

Adding an admin panel option when setting up the template #126

haffi96 opened this issue Oct 5, 2022 · 7 comments

Comments

@haffi96
Copy link

haffi96 commented Oct 5, 2022

Hey 👋🏽

What are opinions on adding an option to add an admin panel/dashboard which just displays the db tables set up in the template?

The dashboard would be served separately

Thinking about options such as:

I'd be happy to pick this up if it's a wanted feature

@haffi96 haffi96 changed the title Thoughts on adding an admin panel option when setting up the template Adding an admin panel option when setting up the template Oct 5, 2022
@s3rius
Copy link
Owner

s3rius commented Oct 5, 2022

Hello, and thanks for raising an issue.

It's a cool idea, but I think it would be hard to implement. Since we can select different ORMs and Databases. Personally I haven't tried a fastapi-admin library, so I don't know if it will work for all possible configurations.

If you want to grab this issue, I'm happy to see your pull request.

@haffi96
Copy link
Author

haffi96 commented Oct 6, 2022

hm, thats a really good point. I was thinking along the lines of, the template can have a 'default' option (will have to be an opinionated choice by yourself) for ORM/db. This doesn't mean remove support for others, keep them but have a default option

We can then chose to either:

  1. Have the option to use admin dashboard to be before the ORM/db selection with a note saying that selecting to use an admin dashboard locks them into using the default ORM/db choice. This is obviously a bigger change
  2. Have option to select use admin dashboard later in the selection process. However, when selection ORM/db. There could be a note saying 'Use the ORM/db option if you want to also use the admin dashboard'
  3. Or lastly, see if there is way to cater for all ORM/db choices. Probably can consider this first however, seems like the more complex and least maintainable option.

wdyt? It's fine if you think this is just not a feasible feature

Also the fastapi-admin has its own ORM implementation with TortoiseORM so that's a limitation. You kind of just need to provide it a db url. But obviously this means, the user may end up having two different ORMs in the project. One for the API and Tortoise for the dashboard

The more i think about it, I'm convincing myself out of doing this feature haha

@s3rius
Copy link
Owner

s3rius commented Oct 6, 2022

I had that question in mind. I don't want to restrict people choose ORMs. So we can add this option in features menu and mark it as unstable.

This feature will work just fine with tortoise ORM, but we cannot provide guarantees about how it's going to work with other ORMs. I guess it's ok to just warn people.

@alldevic
Copy link

May be Amis Admin? https://github.com/amisadmin/fastapi_amis_admin

@s3rius
Copy link
Owner

s3rius commented Jan 12, 2023

May be Amis Admin? https://github.com/amisadmin/fastapi_amis_admin

It looks nice. I'll be ready to add it next week. Or you can submit a PR. On screenshots I've seen only Chinese language. Does it support other languages?

@alldevic
Copy link

It support English and have l11n support. But I not found packs for others langs.

@s3rius
Copy link
Owner

s3rius commented Jan 12, 2023

@alldevic, thanks for researching it. English is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants