Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add branding support #552

Closed
votdev opened this issue May 30, 2023 · 0 comments · Fixed by s3gw-tech/s3gw-ui#197 or s3gw-tech/s3gw-ui#201
Closed

UI: Add branding support #552

votdev opened this issue May 30, 2023 · 0 comments · Fixed by s3gw-tech/s3gw-ui#197 or s3gw-tech/s3gw-ui#201
Assignees
@votdev
Labels
area/ui User Interface kind/enhancement Change that positively impacts existing code
Milestone
v0.17.0

Comments

@votdev
Copy link
Contributor

votdev commented May 30, 2023

Add branding support to be able to customize the UI. This should be done at build time via optional parameter to npm run build:prod.
@votdev votdev added kind/enhancement Change that positively impacts existing code area/ui User Interface labels May 30, 2023
@votdev votdev added this to the v0.18.0 milestone May 30, 2023
@votdev votdev self-assigned this May 30, 2023
@votdev votdev added this to S3GW May 30, 2023
@github-project-automation github-project-automation bot moved this to Backlog in S3GW May 30, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label May 30, 2023
@votdev votdev mentioned this issue May 30, 2023
Closed
votdev referenced this issue in votdev/s3gw-ui Jun 2, 2023
@votdev
UI: Add branding support
d19c389 
Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev mentioned this issue Jun 2, 2023
Merged
3 tasks
votdev referenced this issue in votdev/s3gw-ui Jun 5, 2023
@votdev
UI: Add branding support
f797503 
Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Jun 5, 2023
@votdev
UI: Add branding support
d248f7d 
Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
@github-project-automation github-project-automation bot moved this from Backlog to Done in S3GW Jun 5, 2023
@votdev votdev removed the triage/waiting Waiting for triage label Jun 5, 2023
@votdev votdev modified the milestones: v0.18.0, v0.17.0 Jun 5, 2023
votdev referenced this issue in votdev/s3gw-ui Jun 7, 2023
@votdev
Enhance theming capability
2627246 
Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Jun 7, 2023
@votdev
Enhance theming capability
4c7e8b8 
Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Jun 7, 2023
@votdev
Enhance theming capability
050bd3d 
Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev mentioned this issue Jun 7, 2023
Merged
3 tasks
votdev referenced this issue in votdev/s3gw-ui Jun 7, 2023
@votdev
Enhance theming capability
b6c868d 
- Make sure i18n is loaded during app bootstrapping
- Adapt translation() function to new transloco transpiler feature
- Introduce app.config.json file which contains things that can be customized for branding, e.g. app name and title or help menu items
- Relocate assets to vendor directory
- Fix various theming/CSS things
- Add Longhorn favicon and logo

Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Jun 12, 2023
@votdev
Enhance theming capability
378788f 
- Make sure i18n is loaded during app bootstrapping
- Adapt translation() function to new transloco transpiler feature
- Introduce app.config.json file which contains things that can be customized for branding, e.g. app name and title or help menu items
- Relocate assets to vendor directory
- Fix various theming/CSS things
- Add Longhorn favicon and logo

Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Jun 12, 2023
@votdev
Enhance theming capability
3d1651c 
- Make sure i18n is loaded during app bootstrapping
- Adapt translation() function to new transloco transpiler feature
- Introduce app.config.json file which contains things that can be customized for branding, e.g. app name and title or help menu items
- Relocate assets to vendor directory
- Fix various theming/CSS things
- Add Longhorn favicon and logo

Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Jun 13, 2023
@votdev
Enhance theming capability
d541317 
- Make sure i18n is loaded during app bootstrapping
- Adapt translation() function to new transloco transpiler feature
- Introduce app.config.json file which contains things that can be customized for branding, e.g. app name and title or help menu items
- Relocate assets to vendor directory
- Fix various theming/CSS things
- Add Longhorn favicon and logo

Fixes: https://github.com/aquarist-labs/s3gw/issues/552

Signed-off-by: Volker Theile <vtheile@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@votdev votdev

Labels
area/ui User Interface kind/enhancement Change that positively impacts existing code
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

UI: Add branding support votdev/s3gw-ui
Enhance theming capability votdev/s3gw-ui
1 participant
@votdev