Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #88

Closed
rytilahti opened this issue Oct 8, 2017 · 2 comments
Closed

Add unit tests #88

rytilahti opened this issue Oct 8, 2017 · 2 comments

Comments

@rytilahti
Copy link
Owner

rytilahti commented Oct 8, 2017

The unit test coverage of the library could use some love, maybe someone wants to pick a task to do some hacktoberfest good. Feel free to choose what you want to work! Current state is visible at https://coveralls.io/github/rytilahti/python-miio?branch=master .

@arekbulski
Copy link
Contributor

Someone suggested that maybe you should have a test suite for construct, let me give you two opposite answers with reasons: Yes, because construct never promised backwards/forwards compatibility. API changes whenever there is a good reason to change it. But from this point forward, I will make best effort to get your code uptodate with every release. So No as in no need?

@rytilahti
Copy link
Owner Author

This issue is about tests on our inner workings & the interface we are providing to our downstreams, it's not about testing our dependencies per se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants