From 6dfd14458fded7edf534a089e4bdd6536e89d131 Mon Sep 17 00:00:00 2001 From: Teemu Rytilahti Date: Sat, 21 Oct 2017 19:21:10 +0200 Subject: [PATCH] make hound happy again --- miio/tests/test_yeelight.py | 39 +++++++++++++++++++++++-------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/miio/tests/test_yeelight.py b/miio/tests/test_yeelight.py index f1dd1c3ea..47a77e3ba 100644 --- a/miio/tests/test_yeelight.py +++ b/miio/tests/test_yeelight.py @@ -55,37 +55,39 @@ def dummylight(request): request.cls.device = DummyLight() # TODO add ability to test on a real device + @pytest.mark.usefixtures("dummylight") class TestYeelight(TestCase): def test_status(self): self.device._reset_state() status = self.device.status() # type: YeelightStatus assert status.name == self.device.start_state["name"] - assert status.is_on == False + assert status.is_on is False assert status.brightness == 100 assert status.color_temp == 3584 assert status.color_mode == YeelightMode.ColorTemperature - assert status.developer_mode == True - assert status.save_state_on_change == True + assert status.developer_mode is True + assert status.save_state_on_change is True # following are tested in set mode tests # assert status.rgb == 16711680 # assert status.hsv == (359, 100, 100) def test_on(self): - self.device.off() # make sure we are off - assert self.device.status().is_on == False + self.device.off() # make sure we are off + assert self.device.status().is_on is False self.device.on() - assert self.device.status().is_on == True + assert self.device.status().is_on is True def test_off(self): - self.device.on() # make sure we are on - assert self.device.status().is_on == True + self.device.on() # make sure we are on + assert self.device.status().is_on is True self.device.off() - assert self.device.status().is_on == False + assert self.device.status().is_on is False def test_set_brightness(self): - brightness = lambda: self.device.status().brightness + def brightness(): + return self.device.status().brightness self.device.set_brightness(50) assert brightness() == 50 @@ -100,7 +102,9 @@ def test_set_brightness(self): self.device.set_brightness(200) def test_set_color_temp(self): - color_temp = lambda: self.device.status().color_temp + def color_temp(): + return self.device.status().color_temp + self.device.set_color_temp(2000) assert color_temp() == 2000 self.device.set_color_temp(6500) @@ -132,7 +136,8 @@ def test_set_hsv(self): self.device.set_hsv() def test_set_developer_mode(self): - dev_mode = lambda: self.device.status().developer_mode + def dev_mode(): + return self.device.status().developer_mode orig_mode = dev_mode() self.device.set_developer_mode(not orig_mode) @@ -142,7 +147,9 @@ def test_set_developer_mode(self): assert new_mode is not dev_mode() def test_set_save_state_on_change(self): - save_state = lambda: self.device.status().save_state_on_change + def save_state(): + return self.device.status().save_state_on_change + orig_state = save_state() self.device.set_save_state_on_change(not orig_state) new_state = save_state() @@ -152,14 +159,16 @@ def test_set_save_state_on_change(self): assert new_state is orig_state def test_set_name(self): - name = lambda: self.device.status().name + def name(): + return self.device.status().name assert name() == "test name" self.device.set_name("new test name") assert name() == "new test name" def test_toggle(self): - is_on = lambda: self.device.status().is_on + def is_on(): + return self.device.status().is_on orig_state = is_on() self.device.toggle()