Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated RSS Feeds #41

Open
Aalaizah opened this issue Mar 28, 2015 · 14 comments
Open

Paginated RSS Feeds #41

Aalaizah opened this issue Mar 28, 2015 · 14 comments

Comments

@Aalaizah
Copy link

So I just noticed that my blog uses paginated RSS feeds, which according to what I can find is supported by the RSS standard, but it's causing only 15 posts to show in my participants counter. Is there a way for ofCourse to support this?

@ryansb
Copy link
Owner

ryansb commented Mar 28, 2015

Sure can. Can you give me a link to the RFC section & your blog RSS?

@ryansb
Copy link
Owner

ryansb commented Mar 28, 2015

It's not too tough a feature to add, I'd be happy to teach you how to add & test it if you'd like extra credit in @decause's class.

@Aalaizah
Copy link
Author

http://tools.ietf.org/html/rfc5005#section-3, i believe is the rfc, http://ghost-alexandriamack.rhcloud.com/tag/bizlegal/rss/ is my feed, I'd definitely love to try and add it in for you guys. I'm busy this weekend but can be in IRC on Monday to work on it.

@ryansb
Copy link
Owner

ryansb commented Mar 28, 2015

Sounds great, just hit me up in IRC when you have questions.

@ryansb
Copy link
Owner

ryansb commented Apr 4, 2015

Your blog doesn't actually follow the RFC. It lacks a "next" link.

@liam-middlebrook
Copy link
Collaborator

@ryansb a suggested fix would be to create a supplemental Ghost Blog patch for ofCourse feeds that follows Ghost's structure for paginated RSS.

Basically we would have to do

feed/0
feed/1
...
feed/n

I personally don't think that creating a supplemental patch would be very useful for the future of ofCourse. I think it would be a better idea to have a student submit a patch to Ghost to fix their RSS parsing.

Ultimately I'm on the side of encouraging students to switch their blogs away from Ghost until this issue is fixed. I think it would also give students a great bug to track down and fix in Ghost.

@Aalaizah
Copy link
Author

Aalaizah commented Apr 4, 2015

I noticed this a few days ago and am looking into it. I'll probably be switching my blog away from ghost until I have time to sit down and hopefully fix things.

@ryansb
Copy link
Owner

ryansb commented Jul 3, 2015

Have you had a chance to work on this?

@Aalaizah
Copy link
Author

Aalaizah commented Jul 4, 2015

I have not had a chance to work on this. I'm not sure if I will anytime soon.

@msoucy
Copy link
Collaborator

msoucy commented Dec 3, 2015

As @amm4108 found, the issue for this in upstream seems to be TryGhost/Ghost#2263 (comment)

As that issue has been closed, could someone test to see if it's been fixed? From the comments it doesn't seem to be, but it would be nice to have up-to-date info here.

@Aalaizah
Copy link
Author

Aalaizah commented Dec 3, 2015

I just checked and it has not been fixed in the latest version of Ghost, I'm not sure why they closed the issue but they have supposedly been working on it.

@msoucy
Copy link
Collaborator

msoucy commented Dec 3, 2015

Thanks for checking! I've marked this as "help wanted" so that we can figure out if we really want a ghost-specific handler.

@ghost
Copy link

ghost commented Aug 25, 2017

If I recall correctly, @wilfriedE used Ghost in spring 2016 and might be able to help us test this.

@wilfriedE
Copy link

@ritjoe I did, I can take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants