Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code cannot use Go-Mono because nameID 2 is set to "Book" instead of "Regular" #594

Closed
murphym18 opened this issue Mar 18, 2021 · 3 comments
Milestone

Comments

@murphym18
Copy link

🎯 VS Code cannot use Go-Mono because nameID 2 is set to "Book" instead of "Regular"

VS Code isn't compatible with Go Mono Nerd Font Complete.ttf because name ID 2 has the value Book.

To work around this issue, I used the ttx tool to convert the font to xml. Then I replaced both occurrences of Book with Regular. After that I ran ttx again to convert it back to ttf and installed the font.

🔧 Your Setup

  • I'm using the font Go Mono Nerd Font Complete.ttf
  • VS Code version 1.54.3
  • Pop_OS! 20.04 (based Ubuntu 20.04)

★ Related

@Finii Finii added this to the v2.3.0 milestone Nov 19, 2022
@Finii
Copy link
Collaborator

Finii commented Jan 15, 2023

$ ttfdump -t name Go\ Mono\ Nerd\ Font\ Complete.ttf
[...]
Name table   2.  PlatformID:     1
                 EncodingID:     0
                 LanguageID:     0
                 NameID:         2
                 Length:         4
                 Offset:         259
                 42 6f 6f 6b                    > Book
ttfdump -t name ../../../../src/unpatched-fonts/Go-Mono/Regular/Go-Mono.ttf
[...]
Name table   2.  PlatformID:     1
                 EncodingID:     0
                 LanguageID:     0
                 NameID:         2
                 Length:         7
                 Offset:         72
                 52 65 67 75 6c 61 72           > Regular

@Finii
Copy link
Collaborator

Finii commented Jan 15, 2023

I believe this is fixed ...

$ ./gotta-patch-em-all-font-patcher\!.sh -jc /Go-Mono
# [Nerd Fonts]  Filter given, limiting search and patch to pathname pattern '/Go-Mono'
# [Nerd Fonts]  Total source fonts found: 4
# [Nerd Fonts]  Release timestamp is Sun, 15 Jan 2023 16:50:15 +0100
# [Nerd Fonts]  Processing font 1/4
# [Nerd Fonts]  Processing font 2/4
# [Nerd Fonts]  Processing font 3/4
# [Nerd Fonts]  Processing font 4/4
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Redistributing line gap of 393 (196 top and 197 bottom)
Redistributing line gap of 393 (196 top and 197 bottom)
Redistributing line gap of 393 (196 top and 197 bottom)
Nerd Fonts Patcher v2.3.0-RC (3.4.3) executing
Redistributing line gap of 393 (196 top and 197 bottom)
Done with Patch Sets, generating font...
   Go Mono Nerd Font Complete
   \===> '/home/fini/git/nerd-fonts/check-fonts/Go-Mono/Regular/complete/Go Mono Nerd Font Complete.ttf'
$ ttfdump -t name '/home/fini/git/nerd-fonts/check-fonts/Go-Mono/Regular/complete/Go Mono Nerd Font Complete.ttf'
[...]
Name table   2.	 PlatformID:	 1
		 EncodingID:	 0
		 LanguageID:	 0
		 NameID:	 2
		 Length:	 7
		 Offset:	 265
		 52 65 67 75 6c 61 72           > Regular

Fixed via e97e795 see #1046

@Finii Finii closed this as completed Jan 15, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants