Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate running integration test code against the compiled extension #372

Open
3 tasks
ryanluker opened this issue May 8, 2022 · 4 comments
Open
3 tasks

Comments

@ryanluker
Copy link
Owner

Description

#370 Exposes an issue with how our unit and integration test works compared to the compiled extension code.

AC

  • Investigate using the compiled extension code for integration tests
  • Investigate smoke tests for the compiled vsix
  • Investigate other ways to have caught this issue before release
@mattseddon
Copy link
Collaborator

mattseddon commented May 14, 2022

@ryanluker what was the issue? Why was the build expecting tslib when it wasn't present?

Edit: I did some reading and it seems like you would only need to manually build + install and test the extension when making changes to the tsconfig... this also seems like an edge case as I've never seen the need to install external libs which are not required directly by the code as runtime dependencies before.

@ryanluker
Copy link
Owner Author

ryanluker commented May 16, 2022

@mattseddon No clue on the origin of the issue yet, and I agree that it might be overkill to manually build and install to test, definitely. I was just annoyed that we put out a release that caused regressions for folks when the test suite passing 😅.

The only thing that came to mind was the external extension dependency we have now, but I don't think that would cause us to need the tslib in the runtime deps...

f58addc

@mattseddon
Copy link
Collaborator

The change is when you added importHelpers: true to your tsconfig: https://www.typescriptlang.org/tsconfig#importHelpers

Some code change must've caused a different transpilation and then... you hit the code path where tslib should have been.

@ryanluker
Copy link
Owner Author

@mattseddon Very interesting, it occurred when I was upgrading node to 16 and I applied some more typescript strictness 🤔.
4a58776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants