-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate running integration test code against the compiled extension #372
Comments
@ryanluker what was the issue? Why was the build expecting Edit: I did some reading and it seems like you would only need to manually build + install and test the extension when making changes to the |
@mattseddon No clue on the origin of the issue yet, and I agree that it might be overkill to manually build and install to test, definitely. I was just annoyed that we put out a release that caused regressions for folks when the test suite passing 😅. The only thing that came to mind was the external extension dependency we have now, but I don't think that would cause us to need the tslib in the runtime deps... |
The change is when you added Some code change must've caused a different transpilation and then... you hit the code path where |
@mattseddon Very interesting, it occurred when I was upgrading node to 16 and I applied some more typescript strictness 🤔. |
Description
#370 Exposes an issue with how our unit and integration test works compared to the compiled extension code.
AC
The text was updated successfully, but these errors were encountered: