-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception thrown in Ember canary (3.1) #18
Comments
@rwjblue I can fix it easily by just adding a check, but I'd like to understand what changed in 3.1 to make this fail. |
Ember canary (and soon beta) removed support for |
This was done in emberjs/ember.js#16099 |
We need to make this addon a noop when using Ember 3.0+ (Ember internally supports native event handling when jQuery is not present)... |
I can take care. How would you do it? With ember-version-checker and a funnel to completely remove everything in the addon? |
I think I would use module.exports = {
name: 'ember-native-dom-event-dispatcher',
init() {
this._super && this._super.init.apply(this, arguments);
let checker = new VersionChecker(this);
this._shouldDisable = checker.forEmber().gt('3.0.0-beta.2');
},
treeFor(type) {
if (this._shouldDisable) {
return null;
}
return this._super.treeFor.apply(this, arguments);
}
} |
The exception is that
this._bubbleEvent
is not a function:ember-native-dom-event-dispatcher/addon/index.js
Line 72 in 8c10506
Steps to reproduce it:
"ember-source": "http://builds.emberjs.com/canary/daily/20180110.tgz",
FASTBOOT_DISABLED=true ember serve
The text was updated successfully, but these errors were encountered: