run tests against different Ember CLI versions in CI #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
force-pushed
the
run-tests-against-different-ember-cli-versions
branch
from
1a647a1 to
94eff5f
Compare
jelhan
changed the title
Seems good to me. 3.4, 3.8, and 3.12 sound perfect to me... |
rwjblue
approved these changes
Oct 7, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs our test suite (
yarn test:node) against different Ember CLI versions.I wasn't sure which version we should consider supported. The readme states Ember CLI v2.13 or above but I'm not quite sure if we should take the burden and support such old versions. To be honest I'm even not so motivated to investigate the CI failures for Ember CLI v2.18. If it's okay for you, I would reduce support matrix to v3.4 or above. This would cover three LTS versions.
Before the "normal" ember test suite was run with ember try against different
ember-sourceversions. We don't have any meaningful test in that test suite (yarn test).