Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs don't match released version #111

Closed
mfeckie opened this issue Aug 27, 2019 · 6 comments
Closed

Docs don't match released version #111

mfeckie opened this issue Aug 27, 2019 · 6 comments

Comments

@mfeckie
Copy link

mfeckie commented Aug 27, 2019

The README currently refers to config/content-security-policy.js, but having recently installed this addon and having problems with config not being detected, I dug around and found that the installed version 1.1.1 doesn't include the new code required to read from the config file.

@jelhan
Copy link
Collaborator

jelhan commented Aug 27, 2019

Yeah, sorry. We are in the middle of a refactoring of the configuration. The readme reflects the current master not the last release. Please refer to readme for the version used. E.g. you could access the readme for v1.1 with this link: https://github.com/rwjblue/ember-cli-content-security-policy/blob/v1.1.1/README.md

@rwjblue
Copy link
Owner

rwjblue commented Aug 27, 2019

Sorry this bit you @mfeckie. FWIW, this is a really common problem and folks should generally read the docs of the version they are using. Unfortunately, GH doesn't make that easy (though NPM does a decent job of displaying the README's in that case).

@RobbieTheWagner
Copy link
Sponsor

Is there an ETA on a new release? I just hit this issue as well.

@jelhan
Copy link
Collaborator

jelhan commented Dec 30, 2019

Is there an ETA on a new release? I just hit this issue as well.

We are planing to do a first release candidate soon. See #100 for details.

@wongpeiyi
Copy link

Got hit by this as well. Maybe adding a note in the readme would help

@jelhan
Copy link
Collaborator

jelhan commented Nov 14, 2021

Closing as v2.0.0 has been released finally.

@jelhan jelhan closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants