Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Upgrade React Router to its Latest Version #32

Closed
rwieruch opened this issue May 26, 2017 · 4 comments
Closed

Enhancement: Upgrade React Router to its Latest Version #32

rwieruch opened this issue May 26, 2017 · 4 comments

Comments

@rwieruch
Copy link
Owner

React Router has a lot of breaking changes when using the latest version. Maybe it would be a great PR to upgrade react-router (perhaps also react-redux-router or even get rid of it) to its latest version.

@chriszhangusc
Copy link
Collaborator

Working on it.

@chriszhangusc
Copy link
Collaborator

I have finished the router upgrade, however, I want to propose some changes:

  1. Change browse URL from http://localhost:8080/browse?genre=Minimal to http://localhost:8080/browse/Minimal because in react router v4 we need to parse the query string, the second way it will make the code easier and cleaner to parse the genre from URL.
    See:

  2. Simplify the App Logo to point to browse the default genre, right now it is pointing to the currently selected route.

  3. Probably a typo: change filename from constants/authentification to constants/authentication.

@rwieruch
Copy link
Owner Author

rwieruch commented Jun 7, 2017

Everything sounds great! I would say, go for it 👍

@rwieruch
Copy link
Owner Author

rwieruch commented Jun 7, 2017

#40 perfectly done by @minipekka

@rwieruch rwieruch closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants