Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for license-file in cargo.toml warning #692

Closed
devsnek opened this issue Jul 23, 2019 · 0 comments · Fixed by #693
Closed

Check for license-file in cargo.toml warning #692

devsnek opened this issue Jul 23, 2019 · 0 comments · Fixed by #693
Assignees
@ashleygwilliams
Labels
bug Something isn't working PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Milestone
0.9.0

Comments

@devsnek
Copy link

devsnek commented Jul 23, 2019

With a license-file field, you will still get this warning: Optional field missing from Cargo.toml: 'license'. This is not necessary, but recommended.

It would probably be useful to check for license-file and silence this warning if its provided.
@ashleygwilliams ashleygwilliams added bug Something isn't working PR welcome to-do stuff that needs to happen, so plz do it k thx labels Jul 23, 2019
@ashleygwilliams ashleygwilliams self-assigned this Jul 23, 2019
@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jul 23, 2019
@ashleygwilliams ashleygwilliams mentioned this issue Jul 23, 2019
Merged
@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed PR welcome labels Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashleygwilliams ashleygwilliams

Labels
bug Something isn't working PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

fix(license): don't warn if license-file is present rustwasm/wasm-pack
2 participants
@ashleygwilliams @devsnek