Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle cargo generate temporarily for ease of installation #373

Closed
alexcrichton opened this issue Sep 25, 2018 · 6 comments · Fixed by #623
Closed

Bundle cargo generate temporarily for ease of installation #373

alexcrichton opened this issue Sep 25, 2018 · 6 comments · Fixed by #623
Assignees
Labels
current release current todo items PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@alexcrichton
Copy link
Contributor

💡 Feature description

One of the first steps in the getting started guide is to cargo install cargo-generate, but this can take quite some time and also be difficult to execute in all circumstances (OpenSSL issues, libgit2 issues, etc).

It'd be awesome if instead wasm-pack bundled the code for cargo-generate by default (by using a dependeny on the actual cargo-generate). That way we could have something like wasm-pack generate which is immediately available after downloading wasm-pack. Eventually this wouldn't be necessary if cargo generate becomes more first class, but we could have a note saying that it's just a temporary measure for now!

@ashleygwilliams ashleygwilliams added the to-do stuff that needs to happen, so plz do it k thx label Sep 25, 2018
@ashleygwilliams ashleygwilliams self-assigned this Oct 1, 2018
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 1, 2018
@ashleygwilliams
Copy link
Member

i'd like to tackle this for 0.6.0 - this is blocked by getting libgit2 out of cargo generate and just requiring git as a prerequ (this ends up removing a lot of the grossness of installing cargo-generate)

@alexcrichton
Copy link
Contributor Author

@ashleygwilliams oh wouldn't bundling this in precompiled binaries fix those issues? Using libgit2 is a big benefit for Windows users who don't always have git.exe installed in PATH

@ashleygwilliams
Copy link
Member

oh. hrm. i think you're right. sorry. commented to early. i can have a PR for this today.

@drager
Copy link
Member

drager commented Feb 21, 2019

I should be able to start working on this as soon as possible. Or are you tackling this @ashleygwilliams?

@ashleygwilliams
Copy link
Member

@drager - i was hoping i could tackle this one? would that be ok?

@drager
Copy link
Member

drager commented Feb 21, 2019

@ashleygwilliams: Yes of course!

@ashleygwilliams ashleygwilliams added the current release current todo items label Mar 14, 2019
@ashleygwilliams ashleygwilliams modified the milestones: 0.8.0, 0.9.0 Mar 24, 2019
@ashleygwilliams ashleygwilliams added the PR attached there's a PR open for this issue label Apr 11, 2019
@ashleygwilliams ashleygwilliams mentioned this issue Apr 11, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current release current todo items PR attached there's a PR open for this issue to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants