Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndEntityCert documentation refers to removed methods #270

Closed
tannaurus opened this issue Jul 14, 2024 · 1 comment · Fixed by #271
Closed

EndEntityCert documentation refers to removed methods #270

tannaurus opened this issue Jul 14, 2024 · 1 comment · Fixed by #271

Comments

@tannaurus
Copy link

tannaurus commented Jul 14, 2024 •
edited
Loading

EndEntityCert's documentation is refers to methods that don't exist when describing what needs to be validated for both client and server tls connections

The following functions were deprecated since 0.101.2 and subsequently removed:

  • EndEntityCert.verify_is_valid_tls_server_cert
  • EndEntityCert.verify_is_valid_tls_client_cert

There's also an additional reference to verify_is_valid_tls_server_cert in tests/generate.py
@djc djc mentioned this issue Jul 15, 2024
Merged
@djc
Copy link
Member

djc commented Jul 15, 2024 •
edited
Loading

Oops, that's probably my fault -- should have updated the docs in #133.

Please review the changes in #271.

@cpu cpu closed this as completed in #271 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update EndEntityCert documentation rustls/webpki
2 participants
@djc @tannaurus