Allow canvas size to be controlled by page layout on web target

[alvinhochun]

Currently, the web target uses a fixed window size and it sizes the canvas based on it. It would be nice to instead have a mode that allows the canvas to be laid out on the page with CSS layout like flexbox or CSS grid. The resizing of the element can be detected using ResizeObsever, which can also handle pixel-perfect canvas sizing (#1659 (comment)). In this mode, the winit window should not be resizable by user code.

[ryanisaacg]

I think that's a great idea. I don't have time to implement it myself for now, but I would be happy to review a PR.

[alvinhochun]

I would like to give this a go, but ResizeObserver is still a draft and web-sys` doesn't yet have the bindings (opened rustwasm/wasm-bindgen#2289) which means I will have to write the bindings myself. I'll see how far I can get.

[alvinhochun]

A bit of reflection from my POC experiment:

1. Adding our own ResizeObserver bindings before web-sys adds them is doable.
2. Falling back to window resize event is good enough for most cases but we should document its limitations.
3. Without device-pixel-content-box support, there really is no way to accurately get the canvas backbuffer to be pixel-perfect. All we can use is guesswork. The guesswork I used did seem to work fine though, with the limited number of browsers I've tested.
4. Manual scale and size change tracking is needed to prevent superfluous resize events.
5. The ResizeObserver approach requires using a container element for size reference. The container element also needs some specific CSS styles. Therefore, for this use case it seems better to have the user provide the container element and for winit to manage the canvas element, unlike how it currently works in winit.

[grovesNL]

@alvinhochun for the second point in the list about the fallback path, does winit already add event listeners to window resize events for window resizing (i.e. not only switching between full-screen mode)?

[alvinhochun]

Without checking the source code, I don't recall Winit currently utilizing the window resize event at all, not even for full-screen mode. When I did the POC experiment I added a resize event listener just for the fallback purpose.

[felipellrocha]

What's the status on this? I'm blocked from creating a fullscreen experience without this.

[alvinhochun]

What's the status on this? I'm blocked from creating a fullscreen experience without this.

AFAIK nobody is working on it. I have the rough idea on how it can be done in practice and there is the proof-of-concept. I had wanted to write the final implementation, but I got caught by other personal matters so I don't have an estimate when I would be available to do it.

Another note is that my idea is pretty generic, as it aims to support any CSS page layout positioning, which makes the implementation quite complicated. If your aim is only to have the canvas to fill the page viewport, it is actually much easier to do as you just need to rely on the window resize event without the complexity of ResizeObserver. You can implement it yourself using something like a-b-street/abstreet#388.

[frewsxcv]

There is an open pull request for this: #2074

[developomp]

Pog