Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Missing keyboard navigation code #1590

Open
tim-weis opened this issue Jun 2, 2020 · 1 comment
Open

[Windows] Missing keyboard navigation code #1590

tim-weis opened this issue Jun 2, 2020 · 1 comment
Labels
C - needs investigation Issue must be confirmed and researched DS - windows

Comments

@tim-weis
Copy link

tim-weis commented Jun 2, 2020

winit currently doesn't support keyboard navigation in windows (e.g. TAB navigation). Windows' window manager implements this already (see IsDialogMessageW), but winit doesn't employ it.

It would be great to get support for keyboard navigation in winit out of the box. To get there, all message-retrieval code would need to be revisited and updated to either:

  • include a call to IsDialogMessageW, or
  • arrange for a user-supplied callback, so users can opt-in if they desire.

I acknowledge that neither of these suggestions is trivial to implement, with the latter likely opening up a whole new can of worms.

The following links by Raymond Chen may prove to be helpful in evaluating cost and risk for implementing the former:

@kchibisov kchibisov added DS - windows C - needs investigation Issue must be confirmed and researched labels Jun 3, 2020
@Osspial
Copy link
Contributor

Osspial commented Jul 1, 2020

I don't think it's Winit's place to do this, since there isn't a clear simple API for the feature and (as you said) it's non-trivial to implement. However, once #1508 is merged it should be possible to implement this outside of Winit's codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - needs investigation Issue must be confirmed and researched DS - windows
Development

No branches or pull requests

3 participants