Moving rand_distr code from rand repository

[benjamin-lieser]

To-Do for rust-random/rand#1394

• Move code from rand_distr and distr_test
• Set up CI
• Set up github settings (protected branches, templates, etc ...)
• Decide if the have a separate bench crate or it can life in rand_distr
• Some information how to find old issues and PR because they are not in this repo
• Moving the open issues related to rand_distr
• Delete the code from rand
• v0.5.0 tag

I hope it is ok that I went ahead and created the repo, it is private right now, at some point we have to

• Make this repo public

[benjamin-lieser]

As an alternative for copying the code we can take the git history of rand and remove all the non rand_distr code. This will keep all the attributions but also a lot of unrelated commits.

[dhardy]

Thanks for getting started on this.

We should aim to keep history: https://stackoverflow.com/a/17864475/314345
Yes, there is bound to be some unrelated stuff but the above will filter a lot of it.

The benches crate is slightly problematic; I'd suggest keeping both but removing any bench using rand_distr from the rand repo and the others from this repo (e.g. generators should not use rand_distr code).

[benjamin-lieser]

It seems not straight forward how to do this with multiple directories. Do you have experience with this? If not I can probably figure something out.

Right now I have: Split the 3 directories we want to keep (rand_distr, distr_test, benches) and then use git subtree add to import the other two into the one of rand_distr

This seems to retain all the commits. After splitting rand_distr I only have 300 commits which seems good.

[benjamin-lieser]

It seems splitting out benches retains most of the history https://github.com/benjamin-lieser/rand/tree/benches
distr_test only contains 9 commits, which makes sense.

[dhardy]

Maybe move distr_test and benches into rand_distr first?

[benjamin-lieser]

Maybe move distr_test and benches into rand_distr first?

This does work, not sure why the splitting of benches does not work

[dhardy]

This does work, not sure why the splitting of benches does not work

That would only retain history related to benches, I think?

It looks like what you just pushed is a rebase of sorts? Compare b0bd0f7 to rust-random/rand@e06370c and notice that the changes to distr_test are omitted.

[dhardy]

I repeated what you did — it seems that git subtree split rewrites history in the order seen, ignoring any content outside the directory in question at the time, hence the last commit appears to be pulling distr_test and benches from nowhere. I'll try playing with filter-branch filter-repo.

[dhardy]

I have a filtered history. You haven't pushed much here so far — can I overwrite it?

[benjamin-lieser]

If you find a better solution it would be nice. I think the move first option is good enough.

It is fine if you force push to main right now.

[dhardy]

Done. We now have main and master... I made the latter the primary branch. We can delete the other soon.

I didn't move anything yet — I'll make a PR for that now.

[benjamin-lieser]

Look good :)
I will rebase the PR and make some more changes

[dhardy]

I ticked off some items above. I think once #3 is merged we can make this public, and then start tidying up the rand repo.

[benjamin-lieser]

I ticked off some items above. I think once #3 is merged we can make this public, and then start tidying up the rand repo.

I agree

[dhardy]

We're now public.

[dhardy]

I transferred what I thought were appropriate issues. rust-random/rand#1193 and rust-random/rand#1459 are less obvious.