Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using std feature without bringing in getrandom and rand_chacha dependencies #1339

Closed
Tracked by #1165
SUPERCILEX opened this issue Sep 22, 2023 · 3 comments · Fixed by #1354
Closed
Tracked by #1165

Comments

@SUPERCILEX
Copy link
Contributor

I'd like to be able to use rand with the std feature so I get access to RngReadAdapter, but I don't want to be pulling in getrandom and rand_chacha. There should be a feature split that allows using the stdlib without extra deps.

@dhardy
Copy link
Member

dhardy commented Sep 23, 2023

Sounds reasonable. It's a breaking change but the next release will be v0.9.0 (breaking) anyway.

This requires "rand_chacha?/std" syntax (see here) which is only available from Rust 1.60; the current MSRV is 1.56. I think bumping this is probably reasonable; 1.60 is from April 2022 and even Debian stable includes 1.63 by now.

The more controversial part is dropping getrandom from the std feature. I guess this is fine given that the current default feature is essentially just the current std anyway.

I'll give the other maintainers a chance to comment, but from my side this looks like a good change.

@dhardy
Copy link
Member

dhardy commented Oct 31, 2023

We already bumped the MSRV to 1.60. @SUPERCILEX could you make a PR?

@SUPERCILEX
Copy link
Contributor Author

Done: #1354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants