Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on i686 #3

Closed
osteffenrh opened this issue Jul 17, 2024 · 2 comments · Fixed by #4
Closed

Tests failing on i686 #3

osteffenrh opened this issue Jul 17, 2024 · 2 comments · Fixed by #4
Assignees

Comments

@osteffenrh
Copy link

Tests involving usize or isize fail on i686 (and probably other non-64bit platforms) due to conversion of 64bit literals.

For example:

error: literal out of range for `usize`
 --> src/lib.rs:1155:30
  |
8 | let m = Be::<usize>::from_ne(0xaa00000000006e1);
  |                              ^^^^^^^^^^^^^^^^^
  |
  = note: the literal `0xaa00000000006e1` (decimal `765611936652986081`) does not fit into the type `usize` and will become `1761usize`
  = note: `#[deny(overflowing_literals)]` on by default

I assume everything works fine still, because tests for u64/i64 and bigger are passing.

@mkroening
Copy link
Member

Ah, this makes sense. Thanks for opening an issue!

@osteffenrh
Copy link
Author

Nice! Thanks fixing this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants