Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Scrolling to end of file on format if open in two panes #573

Closed
dusty-phillips opened this issue Apr 12, 2019 · 1 comment
Closed

Scrolling to end of file on format if open in two panes #573

dusty-phillips opened this issue Apr 12, 2019 · 1 comment

Comments

@dusty-phillips
Copy link

Version info:

  • extension version 0.6.1
  • I just ran update the RLS command in VSCode, but not sure how to tell what version of rustup is installed.
  • My local rustup is 1.17.0, and rustc is 1.34.0, but I'm not certain if that's what the extension is using.
  • vscode version is 1.33.0.
  • OS is fedora 29, latest.

Issue:

Sometimes, if I have two vscode panes open to the same file, and I save the file in one pane, it scrolls the second pane to the end of the file.

I am pretty sure this is related to the formatter, but it does not happen if I manually run the "Format Document" command.

It seems to only happen if I make a change that introduces whitespace. If I change the name of a variable, the scrolling behaviour does not happen. However, if I insert a space after an opening parenthesis, or insert one too many newlines, the scrolling behaviour does happen.

Here's a screen-session showing how the right pane scrolls to the end when I ctrl-S:

https://drive.google.com/file/d/1yM63f49dFs6lAokFrHq9xmMyYfgshJaU/view?usp=sharing

@dusty-phillips
Copy link
Author

This is probably related to microsoft/vscode#71707 and seems to be fixed in VSCode 1.33.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant