Support Socket::{join_multicast_v4_n, leave_multicast_v4_n} on OpenBSD

[Thomasdezeeuw]

Effectively reverting #291. Requires ip_mreqn to be added to libc.

[niklasha]

I just checked and a recent commit: rust-lang/libc@2cfa3e9 seems to have added it. Maybe it's just a case of waiting for a new release?

[Thomasdezeeuw]

I just checked and a recent commit: rust-lang/libc@2cfa3e9 seems to have added it. Maybe it's just a case of waiting for a new release?

@niklasha It seems that comment is already in v0.2.114 based on the git tags, if you have an OpenBSD install handy could you check that socket2 works with libc v0.2.114?

[robwahl]

Hello, my name is Robert Wahlstedt and I would like to help with this issue

[Thomasdezeeuw]

Hello, my name is Robert Wahlstedt and I would like to help with this issue

Great! I tried to keep everything working on OpenBSD, but the OpenBSD target not being distributed via rustup makes it a lot harder.

I think the easiest place to start is get the tests running and passing on OpenBSD. This means you'll likely have to add a bunch of cfg such as the following to the code:

socket2/src/lib.rs

Lines 387 to 397 in 4c43681

	#[cfg_attr(target_os = "openbsd", allow(dead_code))]
	time: Option<Duration>,
	#[cfg(not(any(target_os = "openbsd", target_os = "redox", target_os = "solaris")))]
	interval: Option<Duration>,
	#[cfg(not(any(
	target_os = "openbsd",
	target_os = "redox",
	target_os = "solaris",
	target_os = "windows"
	)))]
	retries: Option<u32>,

[robwahl]

Great, I'd get started on it

[niklasha]

All configured tests run already, but perhaps you were referring only to

socket2/tests/socket.rs

Line 1237 in 4c43681

fn join_leave_multicast_v4_n() {

?

[niklasha]

and @Thomasdezeeuw I am sorry, I forgot all about your request from January 29, but I'll gladly let @robwahl do this deed instead :-)