Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display an error if the binary being run doesn't exist in the given toolchain #922

Closed
brson opened this issue Jan 13, 2017 · 2 comments
Closed

Display an error if the binary being run doesn't exist in the given toolchain #922

brson opened this issue Jan 13, 2017 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Jan 13, 2017

Right now rustup will attempt to e.g. run rustdoc blindly in a given toolchain, even if rustdoc doesn't exist (which is possible in e.g. custom toolchains). When this happens rustup will accidentally execute itself infinitely. It could instead check whether the tool actually exists before running it.
@Diggsey
Copy link
Contributor

Diggsey commented Jan 13, 2017

@brson @Manishearth has #917 open to fix this, but the regression test is broken on CI due to there being a global rust installation in the CI environment - might need to hack PATH for the tests - what do you think?

@Diggsey
Copy link
Contributor

Diggsey commented May 3, 2017

This should have been fixed with the last release.

@Diggsey Diggsey closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @Diggsey