Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print new version while rustup self update #542

Closed
liigo opened this issue Jun 23, 2016 · 9 comments
Closed

Print new version while rustup self update #542

liigo opened this issue Jun 23, 2016 · 9 comments

Comments

@liigo
Copy link

liigo commented Jun 23, 2016

before or after update complete.

@brson
Copy link
Contributor

brson commented Jun 24, 2016

I've been indecisive about this. I originally didn't do this because I wanted the rustup version to not be important - it's just continually updated. And with rustup upgrade I think the version of Rust is the most important thing - the version of rustup is not as interesting.

These are the outputs for the two types of updates today

brian@ip-10-145-43-250:~/dev/rustup.rs⟫ rustup self update
info: checking for self-updates
info: downloading self-update
info: rustup updated successfully
brian@ip-10-145-43-250:~/dev/rustup.rs⟫ rustup update
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'beta-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: checking for self-updates
info: rustup is up to date

   stable-x86_64-unknown-linux-gnu unchanged - rustc 1.9.0 (e4e8b6668 2016-05-18)
     beta-x86_64-unknown-linux-gnu unchanged - rustc 1.10.0-beta.2 (39f3c16cc 2016-05-26)
  nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.11.0-nightly (5522e678b 2016-06-20)

Maybe the rustup version could be put on the info log line that mentions the update: "rustup successfully updated to X.Y.Z" . That way with self update it's on the last line, but with update the information is displayed but doesn't distract from the more important toolchain info.

@liigo
Copy link
Author

liigo commented Jun 24, 2016

"rustup successfully updated to X.Y.Z" is nice to have.

@brson
Copy link
Contributor

brson commented Jun 30, 2016

OK, let's change the "rustup updated successfully" message to "rustup successfully updated to X.Y.Z". Getting the version will require running the newly-downloaded bin.

@julienXX
Copy link
Contributor

julienXX commented Jul 6, 2016

Hi I'd like to try to tackle this issue if nobody is already working on it.

@brson
Copy link
Contributor

brson commented Jul 8, 2016

@julienXX You got it!

@brson
Copy link
Contributor

brson commented Jul 15, 2016

@julienXX How's it going?

@julienXX
Copy link
Contributor

@brson sorry been very busy these days but I still intend to submit a PR hopefully in the next few days.

@julienXX
Copy link
Contributor

@brson I've submitted #614 but I'm not sure it's the best way to fix it. What do you think about it?

@brson
Copy link
Contributor

brson commented Jul 25, 2016

Thanks @julienXX ! I added a comment on the PR.

@brson brson closed this as completed in #614 Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants