Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit hash to -V #319

Closed
brson opened this issue Apr 15, 2016 · 2 comments · Fixed by #347
Closed

Add commit hash to -V #319

brson opened this issue Apr 15, 2016 · 2 comments · Fixed by #347

Comments

@brson
Copy link
Contributor

brson commented Apr 15, 2016

No description provided.

@japaric
Copy link
Member

japaric commented Apr 15, 2016

I checked how rustc and cargo do this and they use an env variable provided by the Makefile system. The Makefile fills the env variable by shelling out to git. We could use the same logic here in a build.rs script but it would look as hideous as #314. @brson ?

@brson
Copy link
Contributor Author

brson commented Apr 19, 2016

@japaric Yeah, seems like we should do it.

@japaric japaric mentioned this issue Apr 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add commit hash to the output of -V
2 participants
@brson @japaric