Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for install --profile empty #2970

Open
jyn514 opened this issue Mar 20, 2022 · 3 comments
Open

Add support for install --profile empty #2970

jyn514 opened this issue Mar 20, 2022 · 3 comments

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 20, 2022

Problem you are trying to solve

Bootstrap in rust-lang/rust wants to have a version of rustfmt that's different than the bootstrap compiler toolchain. Right now, to manage it using rustup, we'd have to install a full duplicate toolchain with rustup install --profile minimal. It would be nice to only install the rustfmt component and nothing else.

Solution you'd like

@kinnison and @rbtcollins on Discord agreed to rustup toolchain install --profile empty, which would mean "register this toolchain with rustup" (and I guess download the manifest?), "but don't install any components". That would allow running rustup toolchain install nightly-2022-02-23 --profile empty --component rustfmt in bootstrap.

Notes

cc rust-lang/rust#95136

@kinnison
Copy link
Contributor

To progress this we need to know if rustup will be okay with a manifest-only toolchain. If so then this isn't too awful to implement. It'd also behove us to decide if we want a --force for this or not.

@kinnison
Copy link
Contributor

After brief discussion on Discord, we think --profile empty might be better since it's more explicitly that there won't be things there. I'll edit the title and first post to reflect that, so that we don't have --profile bare front-and-center if someone wants to help.

@kinnison kinnison changed the title Add support for install --profile bare Add support for install --profile empty Mar 22, 2022
@bjorn3
Copy link
Member

bjorn3 commented Mar 24, 2022

In https://rust-lang.zulipchat.com/#narrow/stream/301329-t-devtools/topic/rust-analyzer.20ro.20rust-lang.20org.20transition/near/276493090 it came up that --profile empty could be used to install just the rust-analyzer for a given nightly version without having to install the associated nightly rustc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants