Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of longer download times in download tracker #1547

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

Manishearth
Copy link
Member

Someone on twitter complained that on slow connections Rustup gives progress values like 1234 m 56 s, which is kinda annoying to look at.

I changed it so that past 100 minutes we start counting hours, and past 2 days we start counting days. The days bit may not be necessary.

The cutoff values were taken from wget.

@kinnison
Copy link
Contributor

kinnison commented Jan 6, 2019

I worry that this code is becoming really quite intricate and although the change looks right, it's super-hard to track all the numbers and be certain.

I have, however, spent time looking, and can't find an existing crate which might provide this formatting for us, so I'd begrudgingly 👍 this.

Would you mind rebasing it onto current master and checking the formatting (We've run rustfmt across the codebase and while github says there's no conflicts, things might not be entirely the same) Also that'd have the added benefit of re-kicking the CI checks since rustup.rs has moved since you supplied this patch.

Thanks,

D.

@Manishearth
Copy link
Member Author

The numbers are copied from wget so they should be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants