From 4a682f4434a1068b7798c4a55c32f9690c577d9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=AE=B8=E6=9D=B0=E5=8F=8B=20Jieyou=20Xu=20=28Joe=29?= <39484203+jieyouxu@users.noreply.github.com> Date: Fri, 1 Nov 2024 00:03:43 +0800 Subject: [PATCH 1/2] Fix and update docs for `needs-force-clang-based-tests` --- src/tests/directives.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/tests/directives.md b/src/tests/directives.md index 66ba0d14b..695fa0b60 100644 --- a/src/tests/directives.md +++ b/src/tests/directives.md @@ -190,9 +190,12 @@ The following directives will check LLVM support: - `needs-forced-clang-based-tests` — test is ignored unless the environment variable `RUSTBUILD_FORCE_CLANG_BASED_TESTS` is set, which enables building clang alongside LLVM - - This is only set in one CI job ([`x86_64-gnu-debug`]), which only runs a - tiny subset of `run-make` tests. Other tests with this directive will not + - This is only set in two CI jobs ([`x86_64-gnu-debug`] and + [`aarch64-gnu-debug`]), which only runs a + subset of `run-make` tests. Other tests with this directive will not run at all, which is usually not what you want. + - Notably, the [`aarch64-gnu-debug`] CI job *currently* only runs `run-make` + tests which additionally contain `clang` in their test name. See also [Debuginfo tests](compiletest.md#debuginfo-tests) for directives for ignoring debuggers. @@ -200,6 +203,7 @@ ignoring debuggers. [remote testing]: running.md#running-tests-on-a-remote-machine [compare modes]: ui.md#compare-modes [`x86_64-gnu-debug`]: https://github.com/rust-lang/rust/blob/ab3dba92db355b8d97db915a2dca161a117e959c/src/ci/docker/host-x86_64/x86_64-gnu-debug/Dockerfile#L32 +[`aarch64-gnu-debug`]: https://github.com/rust-lang/rust/blob/20c909ff9cdd88d33768a4ddb8952927a675b0ad/src/ci/docker/host-aarch64/aarch64-gnu-debug/Dockerfile ### Affecting how tests are built From 95ab4759687b16252a7189ce239e682e4a44d853 Mon Sep 17 00:00:00 2001 From: DianQK Date: Mon, 4 Nov 2024 14:17:03 +0800 Subject: [PATCH 2/2] Improve link address for `aarch64-gnu-debug` --- src/tests/directives.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/directives.md b/src/tests/directives.md index 695fa0b60..fe5d304e3 100644 --- a/src/tests/directives.md +++ b/src/tests/directives.md @@ -203,7 +203,7 @@ ignoring debuggers. [remote testing]: running.md#running-tests-on-a-remote-machine [compare modes]: ui.md#compare-modes [`x86_64-gnu-debug`]: https://github.com/rust-lang/rust/blob/ab3dba92db355b8d97db915a2dca161a117e959c/src/ci/docker/host-x86_64/x86_64-gnu-debug/Dockerfile#L32 -[`aarch64-gnu-debug`]: https://github.com/rust-lang/rust/blob/20c909ff9cdd88d33768a4ddb8952927a675b0ad/src/ci/docker/host-aarch64/aarch64-gnu-debug/Dockerfile +[`aarch64-gnu-debug`]: https://github.com/rust-lang/rust/blob/20c909ff9cdd88d33768a4ddb8952927a675b0ad/src/ci/docker/host-aarch64/aarch64-gnu-debug/Dockerfile#L32 ### Affecting how tests are built