From 0143b22c83d884d8010bd2b66ebfd55d5fa94810 Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Sat, 18 Feb 2023 10:32:59 +0200 Subject: [PATCH 1/2] llvm 13 is now not supported --- src/llvm-coverage-instrumentation.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/llvm-coverage-instrumentation.md b/src/llvm-coverage-instrumentation.md index ca2eec97b..a6d26c7d9 100644 --- a/src/llvm-coverage-instrumentation.md +++ b/src/llvm-coverage-instrumentation.md @@ -223,9 +223,8 @@ details of the [_LLVM Coverage Mapping Format_][coverage-mapping-format] (Version 6).[^llvm-and-covmap-versions] [^llvm-and-covmap-versions]: -The Rust compiler (as of Jan 2023) supports _LLVM Coverage Mapping Format_ 6. -It was introduced in _LLVM 13_, which is, as of this writing, -the minimum supported LLVM version. +The Rust compiler (as of Feb 2023) supports _LLVM Coverage Mapping Format_ 6. +It was introduced in _LLVM 13_, which was the minimum supported LLVM version [until early 2023]. The Rust compiler will automatically use the most up-to-date coverage mapping format version that is compatible with the compiler's built-in version of LLVM. @@ -273,6 +272,7 @@ since it will not be called), and adds a new `FunctionCoverage`, with [mapgen-finalize]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/coverageinfo/mapgen/fn.finalize.html [coverage-mapping-format]: https://llvm.org/docs/CoverageMappingFormat.html [add-unused-functions]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/coverageinfo/mapgen/fn.add_unused_functions.html +[until early 2023]: https://github.com/rust-lang/rust/pull/107573 ## Testing LLVM Coverage From 7afd1f8742afd35db936fde693ff95eb50ccf23d Mon Sep 17 00:00:00 2001 From: Tshepang Mbambo Date: Sat, 18 Feb 2023 14:03:40 +0200 Subject: [PATCH 2/2] address review comment See https://github.com/rust-lang/rustc-dev-guide/pull/1612#discussion_r1110988206 --- src/llvm-coverage-instrumentation.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/llvm-coverage-instrumentation.md b/src/llvm-coverage-instrumentation.md index a6d26c7d9..8cd765011 100644 --- a/src/llvm-coverage-instrumentation.md +++ b/src/llvm-coverage-instrumentation.md @@ -224,7 +224,6 @@ details of the [_LLVM Coverage Mapping Format_][coverage-mapping-format] [^llvm-and-covmap-versions]: The Rust compiler (as of Feb 2023) supports _LLVM Coverage Mapping Format_ 6. -It was introduced in _LLVM 13_, which was the minimum supported LLVM version [until early 2023]. The Rust compiler will automatically use the most up-to-date coverage mapping format version that is compatible with the compiler's built-in version of LLVM. @@ -272,7 +271,6 @@ since it will not be called), and adds a new `FunctionCoverage`, with [mapgen-finalize]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/coverageinfo/mapgen/fn.finalize.html [coverage-mapping-format]: https://llvm.org/docs/CoverageMappingFormat.html [add-unused-functions]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/coverageinfo/mapgen/fn.add_unused_functions.html -[until early 2023]: https://github.com/rust-lang/rust/pull/107573 ## Testing LLVM Coverage