Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning attribute missing in diagnostics derive macro reference #1704

Closed
nicklimmm opened this issue Jun 27, 2023 · 1 comment · Fixed by #1765
Closed

warning attribute missing in diagnostics derive macro reference #1704

nicklimmm opened this issue Jun 27, 2023 · 1 comment · Fixed by #1765

Comments

@nicklimmm
Copy link
Contributor

nicklimmm commented Jun 27, 2023

Previously, the warn_ attribute is used to add warning diagnostics. But it was changed to warning in this PR.

Some information is also outdated in both Diagnostic and Subdiagnostic derives, e.g. no warning reference in Subdiagnostic, the attribute is also applicable on structs.

Diagnostic derive documentation from nightly rustc (source of truth):

What we have in the guide instead:

Updating the warning references in the guide can help new contributors to support the translation effort (issue tracker rust-lang/rust#100717)

@nicklimmm
Copy link
Contributor Author

If this looks good, I'd like to update the docs accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant