Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch #99955

Closed
est31 opened this issue Jul 30, 2022 · 0 comments · Fixed by #99956
Closed

warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch #99955

est31 opened this issue Jul 30, 2022 · 0 comments · Fixed by #99956
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Jul 30, 2022

On recent master, compiling gives me this warning in stdout:

warning: llvm-wrapper/RustWrapper.cpp:159:11: warning: enumeration values 'AllocatedPointer' and 'AllocAlign' not handled in switch [-Wswitch]
warning:   switch (Kind) {
warning:           ^
warning: 1 warning generated.

Now, they are handled in the switch case, but are gated by LLVM_VERSION_GE. I think this is a fall out of #99574. The issue is probably fixed by adding similar gating to LLVMWrapper.h .

@rustbot label A-llvm T-compiler
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2022
@est31 est31 mentioned this issue Jul 30, 2022
Merged
@bors bors closed this as completed in b9ad36c Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE est31/rust
2 participants
@est31 @rustbot