Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate bootstrap documentation #90686

Closed
jyn514 opened this issue Nov 8, 2021 · 6 comments · Fixed by #107116
Closed

Consolidate bootstrap documentation #90686

jyn514 opened this issue Nov 8, 2021 · 6 comments · Fixed by #107116
Assignees
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Nov 8, 2021

Right now, there are docs for x.py in a bunch of different places:

It would be nice to consolidate these some; e.g. lib.rs can probably just point to the README, and lots of the information in the readme is duplicated in the dev-guide and can be deleted and replaced with a link.

cc @Mark-Simulacrum - do you have strong opinions on this?

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 8, 2021
@Mark-Simulacrum
Copy link
Member

No, seems good to consolidate. I personally think we might get something out of ending up with two guides, one of which discusses the content from an internal perspective (e.g., Step, how to add new targets) and another from an external perspective, focusing on what users need to know.

I think most of the existing documentation is sort of in the second of those, but also (potentially correctly, hard for me to say) treats things as a very leaky abstraction and documents a lot of the internals too. I think some of this is our audience, but I do wonder if a much simpler message is possible with just a few standard commands depending on what they want to build, and documenting specific outputs rather than the whole layout. I think right now we're trying to explain things by teaching everything, but perhaps we can get away with not teaching the internals of the abstraction.

Anyway, mostly musing, no strong opinions here.

@jyn514 jyn514 added E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Nov 8, 2021
@jyn514
Copy link
Member Author

jyn514 commented Nov 30, 2022

We should also document that we support suffixes instead of full paths (e.g. miri instead of src/tools/miri): rust-lang/miri#2698 (comment)

@albertlarsan68
Copy link
Member

Hello,

Should I start working on adding doc-comments in bootstrap ?

@jyn514
Copy link
Member Author

jyn514 commented Jan 13, 2023

@albertlarsan68 more doc-comments are always welcome :) but when I wrote the issue I was imagining coming up for a plan for how to organize the standalone documentation. maybe we can put the internal documentation in src/bootstrap/README and the user facing documentation in the guide?

@onur-ozkan
Copy link
Member

@rustbot claim

@onur-ozkan
Copy link
Member

Maybe we can put the internal documentation in src/bootstrap/README and the user facing documentation in the guide?

I like the idea and I think this standard should be applied in general since this seperation reduces cost of the maintaince and makes dev-guide more understandable and simple for users.

I will follow that idea in the refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants