Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debuginfo type names for dyn types are incomplete #86134

Closed
michaelwoerister opened this issue Jun 8, 2021 · 0 comments · Fixed by #87153
Closed

Debuginfo type names for dyn types are incomplete #86134

michaelwoerister opened this issue Jun 8, 2021 · 0 comments · Fixed by #87153
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

The current implementation does not handle associated type bindings and auto-traits which leads to information about the type being lost. For example, &dyn Iterator<Item=u32> + Send will be mapped to &dyn Iterator and &dyn Send + Sync will be mapped to & dyn '_.

Some consumers of debuginfo (e.g. NatVis) rely on these type names to be unambiguous identifiers of the type they represent so we must not lose information about assoc type bindings and auto-traits.

@michaelwoerister michaelwoerister added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Jun 8, 2021
@bors bors closed this as completed in 014026d Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant