Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail tests that have a --target compile-flag, but not needs-llvm-components #82405

Closed
nagisa opened this issue Feb 22, 2021 · 0 comments · Fixed by #86272
Closed

Fail tests that have a --target compile-flag, but not needs-llvm-components #82405

nagisa opened this issue Feb 22, 2021 · 0 comments · Fixed by #86272
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@nagisa
Copy link
Member

nagisa commented Feb 22, 2021

Typically when writing a target-specific test, one'll specify a --target compilation flag, but the test will fail when the LLVM does not have the corresponding targets enabled. This is mitigated by telling compiletest that certain llvm components are required in order to run said test. The header looks like this: needs-llvm-components: aarch64.

We should make sure that presence of this annotation is enforced by tidy or compiletest itself when --target flag is used.

@nagisa nagisa changed the title Tidy-fail tests that have a --target compile-flag, but not needs-llvm-components Fail tests that have a --target compile-flag, but not needs-llvm-components Feb 22, 2021
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Feb 22, 2021
@bors bors closed this as completed in d4e7cb3 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
2 participants